Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: createRequire can take import.meta.url directly #30495

Closed

Conversation

@GeoffreyBooth
Copy link
Member

GeoffreyBooth commented Nov 15, 2019

This PR updates the createRequire example in https://nodejs.org/api/esm.html#esm_commonjs_json_and_native_modules to follow the new createRequire behavior, as opposed to the deprecated createRequireFromPath behavior. cc @MylesBorins

Checklist
Copy link
Member

MylesBorins left a comment

Lgtm

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Nov 15, 2019

Can we please fast-track

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Nov 16, 2019

Landed in 79126fc

MylesBorins added a commit that referenced this pull request Nov 16, 2019
PR-URL: #30495
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@GeoffreyBooth GeoffreyBooth deleted the GeoffreyBooth:fix-create-require-example branch Nov 16, 2019
MylesBorins added a commit that referenced this pull request Nov 17, 2019
PR-URL: #30495
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30495
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30495
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.