Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored test-dgram-multicast-set-interface-lo.js by converting fun… #30536

Closed
wants to merge 1 commit into from

Conversation

@taylor009
Copy link

taylor009 commented Nov 18, 2019

…ctions to arrow functions. Removed unused param('signal') from function to handle the death of a worker.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • [x ] commit message follows commit guidelines
…ctions to arrow functions. Removed unused param('signal') from function to handle the death of a worker.
@Trott
Trott approved these changes Nov 19, 2019
@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 19, 2019

If I didn't mess it up, internet test suite CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/10181/

@Trott Trott added the author ready label Nov 19, 2019
@Trott
Trott approved these changes Nov 22, 2019
Trott added a commit that referenced this pull request Nov 22, 2019
Convert functions to arrow functions. Remove unused param('signal') from
function.

PR-URL: #30536
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 22, 2019

Landed in a18ec07.

Thanks for the contribution! 🎉

@Trott Trott closed this Nov 22, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
Convert functions to arrow functions. Remove unused param('signal') from
function.

PR-URL: #30536
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Dec 1, 2019
Convert functions to arrow functions. Remove unused param('signal') from
function.

PR-URL: #30536
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Convert functions to arrow functions. Remove unused param('signal') from
function.

PR-URL: #30536
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.