Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for options validation of createServer #30541

Closed

Conversation

@ZYSzys
Copy link
Member

ZYSzys commented Nov 19, 2019

test: add test for options validation of http2.createServer
and http2.createSecureServer

http2: remove duplicated assertIsObject
We have invoke initializeOptions(options) in Http2Server and Http2SecureServer's constructor, and we do assertIsObject(options, 'options') in initializeOptions(options), so the assertIsObject(options, 'options') in createServer and createSecureServer are duplicated.

function initializeOptions(options) {
assertIsObject(options, 'options');

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@ZYSzys ZYSzys added the http2 label Nov 19, 2019
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes Nov 19, 2019
ZYSzys added a commit that referenced this pull request Nov 21, 2019
PR-URL: #30541
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ZYSzys added a commit that referenced this pull request Nov 21, 2019
PR-URL: #30541
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ZYSzys

This comment has been minimized.

Copy link
Member Author

ZYSzys commented Nov 21, 2019

Landed in 8138e9c...a7c13cf.

@ZYSzys ZYSzys closed this Nov 21, 2019
@ZYSzys ZYSzys deleted the zys-contribs:test-http2-createserver-options branch Nov 21, 2019
MylesBorins added a commit that referenced this pull request Nov 21, 2019
PR-URL: #30541
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 21, 2019
PR-URL: #30541
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 21, 2019
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30541
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30541
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30541
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30541
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.