Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test-dgram-send-cb-quelches-error #30545

Closed
wants to merge 0 commits into from
Closed

Conversation

@Trott
Copy link
Member

Trott commented Nov 19, 2019

  • When an error occurs unexpectedly, let the user know what the error is.
  • RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
    names that are sure to be invalid and which it is obvious at a glance
    are invalid." Replace dne.example.com which actually isn't guaranteed
    to not exist. (example.com is for examples, but at least one address
    does in fact exist in that TLD.)
  • test-dgram-send-cb-quelches-error works with or without a network. Move
    to parallel directory.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 19, 2019

@joyeecheung Would you be able to confirm that this test (or at least this test with the modifications here) works for you in whatever environment you might have available that has a challenge connecting to the wider Internet? It works for me with no network, but some confirmation from you would be helpful.

@nodejs-github-bot

This comment was marked as outdated.

@Trott Trott added the author ready label Nov 19, 2019
@joyeecheung

This comment has been minimized.

Copy link
Member

joyeecheung commented Nov 19, 2019

@Trott Works for me currently (though my ISP is not hijacking unknown hosts today).

@lpinca
lpinca approved these changes Nov 19, 2019
@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Nov 20, 2019

Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2019
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2019
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2019
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott closed this Nov 21, 2019
@Trott Trott force-pushed the Trott:quelch branch from c8fa171 to 03b5c46 Nov 21, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 21, 2019

Landed in 9fbad51...03b5c46

@Trott Trott deleted the Trott:quelch branch Nov 21, 2019
MylesBorins added a commit that referenced this pull request Nov 21, 2019
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 21, 2019
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 21, 2019
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 21, 2019
targos added a commit that referenced this pull request Dec 1, 2019
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.