Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing 'added' versions to module.builtinModules #30562

Closed
wants to merge 1 commit into from

Conversation

@watson
Copy link
Member

watson commented Nov 20, 2019

This was backported later, but the documentation wasn't updated.

Checklist
@watson watson added the fast-track label Nov 20, 2019
@watson watson self-assigned this Nov 20, 2019
@watson

This comment has been minimized.

Copy link
Member Author

watson commented Nov 20, 2019

Please upvote if we should fast-track this

@watson watson added the author ready label Nov 20, 2019
@watson watson force-pushed the watson:builtin branch from 9723c5a to 50876fa Nov 20, 2019
@watson

This comment has been minimized.

Copy link
Member Author

watson commented Nov 20, 2019

Force pushed as I was off by one on the 6.x branch because I couldn't read (wrote 6.13.1 instead of 6.13.0). For reference, here's the PR that was backported: #16386

@lpinca
lpinca approved these changes Nov 20, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
PR-URL: #30562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Nov 30, 2019

Landed in ab2afa3

@addaleax addaleax closed this Nov 30, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
PR-URL: #30562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@watson watson deleted the watson:builtin branch Dec 2, 2019
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos added a commit that referenced this pull request Dec 5, 2019
PR-URL: #30562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
PR-URL: nodejs#30562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30562
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.