Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor test #30568

Closed
wants to merge 2 commits into from
Closed

refactor test #30568

wants to merge 2 commits into from

Conversation

@JenyMzo
Copy link
Contributor

JenyMzo commented Nov 20, 2019

Switch the argument order for the assertion to be in the correct order (actual, expected).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott Trott added the author ready label Nov 20, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 21, 2019

06:36:04 ok 2756 sequential/test-inspector-module
06:36:04   ---
06:36:04   duration_ms: 0.219
06:36:04   ...
06:39:52 FATAL: command execution failed
06:39:52 java.nio.channels.ClosedChannelException
06:39:52 	at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer.onReadClosed(ChannelApplicationLayer.java:209)
06:39:52 	at org.jenkinsci.remoting.protocol.ApplicationLayer.onRecvClosed(ApplicationLayer.java:222)
06:39:52 	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecvClosed(ProtocolStack.java:816)
06:39:52 	at org.jenkinsci.remoting.protocol.FilterLayer.onRecvClosed(FilterLayer.java:287)
06:39:52 	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.onRecvClosed(SSLEngineFilterLayer.java:181)
06:39:52 	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.switchToNoSecure(SSLEngineFilterLayer.java:283)
06:39:52 	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processWrite(SSLEngineFilterLayer.java:503)

looks like the some infra issues caused the CI to fail. Let us see if a resume build fixes that.

@nodejs-github-bot

This comment has been minimized.

@JenyMzo JenyMzo changed the title refactor test test: refactor createHook rest Nov 21, 2019
@JenyMzo JenyMzo changed the title test: refactor createHook rest test: refactor createHook test Nov 21, 2019
@JenyMzo JenyMzo changed the title test: refactor createHook test refactor test Nov 21, 2019
@JenyMzo JenyMzo force-pushed the JenyMzo:test-createHook branch from 103a293 to 50a71ad Nov 21, 2019
Copy link
Contributor

jessecogollo left a comment

you rock !!! 👏 🚀

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 30, 2019

the only failure in linix-containerized parallel/test-readline-async-iterators-destroy is known as in #30660

gireeshpunathil added a commit that referenced this pull request Nov 30, 2019
PR-URL: #30568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 30, 2019

landed in 246557e.

thanks for the contribution!

addaleax added a commit that referenced this pull request Nov 30, 2019
PR-URL: #30568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos added a commit that referenced this pull request Dec 5, 2019
PR-URL: #30568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
PR-URL: nodejs#30568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.