Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: improve performance caused by primordials #30577

Closed
wants to merge 1 commit into from

Conversation

@antimonyGu
Copy link
Contributor

antimonyGu commented Nov 21, 2019

Checklist

Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
ownKeys: ReflectOwnKeys,
}
} = primordials;
const apply = ReflectApply;

This comment has been minimized.

Copy link
@cjihrig

cjihrig Nov 21, 2019

Contributor

The variables ReflectApply and apply are the same thing. I think one of them can be removed.

This comment has been minimized.

Copy link
@antimonyGu

antimonyGu Nov 21, 2019

Author Contributor

That's right. I have changed it. Thanks!

@antimonyGu antimonyGu force-pushed the antimonyGu:events-primordials branch from 916086e to 175a3a5 Nov 21, 2019
@targos
targos approved these changes Nov 21, 2019
@ZYSzys
ZYSzys approved these changes Nov 22, 2019
@nodejs-github-bot

This comment has been minimized.

@antimonyGu

This comment has been minimized.

Copy link
Contributor Author

antimonyGu commented Nov 22, 2019

Dear all reviewers,

I see several builds fails on Jenkins, and most of them seem like a same problem. But I don't know how to fix them and the exact reason of the failure reason. Can anybody help me? Thanks very much!

@nodejs-github-bot

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 22, 2019

@antimonyGu - there were unrelated issues that caused this failures, not a cause of worry for you!

those are being addressed, so I have re-triggered the CI. Let us see!

@antimonyGu

This comment has been minimized.

Copy link
Contributor Author

antimonyGu commented Nov 22, 2019

@gireeshpunathil Thanks very much!

@targos targos added the fast-track label Nov 22, 2019
@targos

This comment has been minimized.

Copy link
Member

targos commented Nov 22, 2019

Please 👍 to fast-track.

Trott added a commit that referenced this pull request Nov 23, 2019
PR-URL: #30577
Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 23, 2019

Landed in e5cbbe0.

Thanks for the contribution! 🎉

@Trott Trott closed this Nov 23, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
PR-URL: #30577
Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30577
Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30577
Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.