Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 6.7.1 #30598

Merged
merged 2 commits into from Nov 25, 2019
Merged

tools: update ESLint to 6.7.1 #30598

merged 2 commits into from Nov 25, 2019

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Nov 22, 2019

This also enables a handful of new ESLint rules that were added in 6.7.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Nov 22, 2019
@targos
targos approved these changes Nov 22, 2019
@cjihrig cjihrig force-pushed the cjihrig:eslint branch from 3fb3165 to e4cc7dc Nov 25, 2019
@cjihrig cjihrig changed the title tools: update ESLint to 6.7.0 tools: update ESLint to 6.7.1 Nov 25, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Nov 25, 2019

There is one remaining failure on ubuntu1804_sharedlibs_shared_x64:

11:22:55 not ok 2591 node-api/test_make_callback/test-async-hooks-gcable
11:22:55   ---
11:22:55   duration_ms: 0.267
11:22:55   severity: crashed
11:22:55   exitcode: -11
11:22:55   stack: |-
11:22:55   ...

That test has failed on a few runs now, including in other PRs (https://ci.nodejs.org/job/node-test-commit-linux-containered/16163/). Since an ESLint update is unlikely to cause this failure, and because it's showing up elsewhere, I'm going to move forward with landing this.

cjihrig added 2 commits Nov 22, 2019
Update ESLint to 6.7.1

PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit enables these new in ESLint 6.7.0 rules:

- no-constructor-return
- no-dupe-else-if
- no-setter-return

PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig cjihrig force-pushed the cjihrig:eslint branch from e4cc7dc to a50cc2e Nov 25, 2019
@cjihrig cjihrig merged commit a50cc2e into nodejs:master Nov 25, 2019
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Nov 25, 2019

Landed in 02d4c74...a50cc2e.

@cjihrig cjihrig deleted the cjihrig:eslint branch Nov 25, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
Update ESLint to 6.7.1

PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax added a commit that referenced this pull request Nov 30, 2019
This commit enables these new in ESLint 6.7.0 rules:

- no-constructor-return
- no-dupe-else-if
- no-setter-return

PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
Update ESLint to 6.7.1

PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
This commit enables these new in ESLint 6.7.0 rules:

- no-constructor-return
- no-dupe-else-if
- no-setter-return

PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Update ESLint to 6.7.1

PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
This commit enables these new in ESLint 6.7.0 rules:

- no-constructor-return
- no-dupe-else-if
- no-setter-return

PR-URL: #30598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.