Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document "Resume Build" limitation #30604

Merged
merged 1 commit into from Nov 26, 2019
Merged

Conversation

@richardlau
Copy link
Member

richardlau commented Nov 22, 2019

Compiled binaries for fanned CI builds on Windows and ARM are only kept
for seven days. Document that a fresh CI should be started if more than
seven days have elapsed since the original failing CI.

Refs: nodejs/build#1515 (comment)

cc @BethGriggs

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@richardlau

This comment has been minimized.

Copy link
Member

addaleax left a comment

Just for my understanding, if, say, only AIX failed, then this would not matter (even though it may be a good idea to start a fresh CI anyway)?

@richardlau

This comment has been minimized.

Copy link
Member Author

richardlau commented Nov 22, 2019

Just for my understanding, if, say, only AIX failed, then this would not matter (even though it may be a good idea to start a fresh CI anyway)?

Yes, that's correct. I tried to keep the doc changes brief and simple. It is probably a good idea to start a new CI after seven days anyway to pick up changes in the branch being merged into.

@lpinca
lpinca approved these changes Nov 23, 2019
Compiled binaries for fanned CI builds on Windows and ARM are only kept
for seven days.

PR-URL: #30604
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau force-pushed the richardlau:collaborator branch from bc1d94c to f3a5097 Nov 26, 2019
@richardlau

This comment has been minimized.

Copy link
Member Author

richardlau commented Nov 26, 2019

Landed in f3a5097.

@richardlau richardlau merged commit f3a5097 into nodejs:master Nov 26, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
addaleax added a commit that referenced this pull request Nov 30, 2019
Compiled binaries for fanned CI builds on Windows and ARM are only kept
for seven days.

PR-URL: #30604
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
Compiled binaries for fanned CI builds on Windows and ARM are only kept
for seven days.

PR-URL: #30604
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Compiled binaries for fanned CI builds on Windows and ARM are only kept
for seven days.

PR-URL: #30604
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.