Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test for minimum ICU version consistency #30608

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@richardlau
Copy link
Member

richardlau commented Nov 23, 2019

The minimum ICU version for Node.js must be at least the minimum ICU
version for V8.

Refs: #30607

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@richardlau richardlau mentioned this pull request Nov 23, 2019
3 of 3 tasks complete
@richardlau richardlau added the intl label Nov 23, 2019
@nodejs-github-bot

This comment has been minimized.

@srl295
srl295 approved these changes Nov 23, 2019
Copy link
Member

srl295 left a comment

LGTM… Gotta be careful what you say around here, docs turn into code !

edit now my docs PR is out of date :)

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Nov 23, 2019

The minimum ICU version for Node.js must be at least the minimum ICU
version for V8.

PR-URL: #30608
Refs: #30607
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@richardlau richardlau force-pushed the richardlau:mininum-icu branch from 3dab3f0 to f2060fa Nov 26, 2019
@richardlau richardlau self-assigned this Nov 26, 2019
@richardlau richardlau merged commit f2060fa into nodejs:master Nov 26, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@richardlau

This comment has been minimized.

Copy link
Member Author

richardlau commented Nov 26, 2019

Landed in f2060fa.

@richardlau richardlau deleted the richardlau:mininum-icu branch Nov 26, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
The minimum ICU version for Node.js must be at least the minimum ICU
version for V8.

PR-URL: #30608
Refs: #30607
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
The minimum ICU version for Node.js must be at least the minimum ICU
version for V8.

PR-URL: #30608
Refs: #30607
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
The minimum ICU version for Node.js must be at least the minimum ICU
version for V8.

PR-URL: #30608
Refs: #30607
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.