Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use useful message argument in test function #30618

Merged
merged 1 commit into from Nov 26, 2019
Merged

Conversation

@Trott
Copy link
Member

Trott commented Nov 24, 2019

The message argument of two test functions in
test-inspector-async-call-stack is useful but unused. Use it!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes Nov 24, 2019
@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Nov 24, 2019

@ZYSzys
ZYSzys approved these changes Nov 24, 2019
@Trott Trott added the author ready label Nov 24, 2019
The message argument of two test functions in
test-inspector-async-call-stack is useful but unused. Use it!

PR-URL: #30618
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott Trott force-pushed the Trott:the-message branch from 56b264a to a6fd282 Nov 26, 2019
@Trott Trott merged commit a6fd282 into nodejs:master Nov 26, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 26, 2019

Landed in a6fd282

addaleax added a commit that referenced this pull request Nov 30, 2019
The message argument of two test functions in
test-inspector-async-call-stack is useful but unused. Use it!

PR-URL: #30618
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos added a commit that referenced this pull request Dec 1, 2019
The message argument of two test functions in
test-inspector-async-call-stack is useful but unused. Use it!

PR-URL: #30618
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
The message argument of two test functions in
test-inspector-async-call-stack is useful but unused. Use it!

PR-URL: #30618
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.