Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip test-domain-error-types in debug mode temporariliy #30629

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@Trott
Copy link
Member

Trott commented Nov 24, 2019

Until #30498 is resolved, skip
test-domain-error-types on debug builds.

Not my first choice, but the frequency of failures in container+debug+shared-lib here is a problem.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@Trott Trott force-pushed the Trott:skip-it branch from ce36956 to ccaa188 Nov 25, 2019
@nodejs-github-bot

This comment has been minimized.

test/parallel/parallel.status Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment has been minimized.

@Trott Trott added the author ready label Nov 25, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 25, 2019

With the .status file approach, the test now doesn't show up at all in the results for the debug build. I would have thought it would be green-on-pass/yellow-on-fail. I'm puzzled by that. It is showing up in non-debug builds as expected.

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Nov 25, 2019

@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Nov 25, 2019

With the .status file approach, the test now doesn't show up at all in the results for the debug build. I would have thought it would be green-on-pass/yellow-on-fail. I'm puzzled by that. It is showing up in non-debug builds as expected.

#30629 (comment)

Until #30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: #30629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott force-pushed the Trott:skip-it branch from 50d4dcc to 6d022c1 Nov 26, 2019
@Trott Trott merged commit 6d022c1 into nodejs:master Nov 26, 2019
1 check failed
1 check failed
Travis CI - Pull Request Build Errored
Details
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 26, 2019

Landed in 6d022c1

@Trott Trott deleted the Trott:skip-it branch Nov 26, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
Until #30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: #30629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
bmeck added a commit to bmeck/node that referenced this pull request Dec 2, 2019
Until nodejs#30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: nodejs#30629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
BethGriggs added a commit that referenced this pull request Dec 23, 2019
Until #30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: #30629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Dec 27, 2019
BethGriggs added a commit that referenced this pull request Dec 31, 2019
Until #30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: #30629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.