Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: remove "this API is unstable" note #30631

Closed
wants to merge 1 commit into from
Closed

Conversation

@bruce-one
Copy link
Contributor

bruce-one commented Nov 24, 2019

As #30234 marked this as stable I think this line should be removed as well?

As #30234 marked this as stable I think this line should be removed as well?
Copy link
Member

bnoordhuis left a comment

Good catch. Interesting that the other PR was signed off by no fewer than 9 people and no one noticed. ^^

@gengjiawen

This comment has been minimized.

Copy link
Member

gengjiawen commented Nov 25, 2019

Good catch. Interesting that the other PR was signed off by no fewer than 9 people and no one noticed. ^^

Perhaps because the default github diff doesn't show this text.

@lpinca
lpinca approved these changes Nov 25, 2019
addaleax added a commit that referenced this pull request Nov 27, 2019
As #30234 marked this as stable I think this line
should be removed as well?

Refs: #30234
PR-URL: #30631
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Nov 27, 2019

Landed in 84aa192, thanks for noticing this and opening a PR! 🎉

@addaleax addaleax closed this Nov 27, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
As #30234 marked this as stable I think this line
should be removed as well?

Refs: #30234
PR-URL: #30631
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
As #30234 marked this as stable I think this line
should be removed as well?

Refs: #30234
PR-URL: #30631
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
bmeck added a commit to bmeck/node that referenced this pull request Dec 2, 2019
As nodejs#30234 marked this as stable I think this line
should be removed as well?

Refs: nodejs#30234
PR-URL: nodejs#30631
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
As nodejs#30234 marked this as stable I think this line
should be removed as well?

Refs: nodejs#30234
PR-URL: nodejs#30631
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
As #30234 marked this as stable I think this line
should be removed as well?

Refs: #30234
PR-URL: #30631
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.