Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: document kill() return value #30669

Merged
merged 1 commit into from Nov 29, 2019
Merged

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Nov 26, 2019

This commit documents the return value from subprocess.kill().

Refs: #30668

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@jgehrcke

This comment has been minimized.

Copy link
Contributor

jgehrcke commented Nov 26, 2019

Thank you, @cjihrig!

@lpinca
lpinca approved these changes Nov 26, 2019
doc/api/child_process.md Outdated Show resolved Hide resolved
@cjihrig cjihrig force-pushed the cjihrig:kill-ret branch from 917d49d to 86819dd Nov 29, 2019
This commit documents the return value from subprocess.kill().

PR-URL: #30669
Refs: #30668
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig force-pushed the cjihrig:kill-ret branch from 86819dd to 84a25eb Nov 29, 2019
@cjihrig cjihrig merged commit 84a25eb into nodejs:master Nov 29, 2019
0 of 2 checks passed
0 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Created
Details
@cjihrig cjihrig deleted the cjihrig:kill-ret branch Nov 29, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
This commit documents the return value from subprocess.kill().

PR-URL: #30669
Refs: #30668
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos added a commit that referenced this pull request Dec 5, 2019
This commit documents the return value from subprocess.kill().

PR-URL: #30669
Refs: #30668
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
This commit documents the return value from subprocess.kill().

PR-URL: nodejs#30669
Refs: nodejs#30668
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
This commit documents the return value from subprocess.kill().

PR-URL: #30669
Refs: #30668
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.