Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release doc #30673

Closed
wants to merge 1 commit into from
Closed

Conversation

@MylesBorins
Copy link
Member

MylesBorins commented Nov 26, 2019

Two different changes

  • Update algorithm in document to reflect the state of the script
  • Bold statement about how to re sign.
@rvagg
rvagg approved these changes Nov 26, 2019
doc/releases.md Outdated Show resolved Hide resolved
@rvagg
rvagg approved these changes Nov 28, 2019
Updated doc to reflect what is now done in tools/release.sh
@MylesBorins MylesBorins force-pushed the MylesBorins:update-release-doc branch from 84a044e to 73b16b6 Nov 28, 2019
danbev added a commit that referenced this pull request Dec 2, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 2, 2019

Landed in c5fc802.

@danbev danbev closed this Dec 2, 2019
targos added a commit that referenced this pull request Dec 2, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos added a commit that referenced this pull request Dec 5, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: nodejs#30673
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
BethGriggs added a commit that referenced this pull request Dec 31, 2019
Updated doc to reflect what is now done in tools/release.sh

PR-URL: #30673
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.