Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise socket.connect() note #30691

Closed
wants to merge 1 commit into from
Closed

doc: revise socket.connect() note #30691

wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

Trott commented Nov 27, 2019

Edit note in about onread option to socket.connect() for clarity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Edit note in about `onread` option to `socket.connect()` for clarity.
@Trott Trott added the author ready label Nov 28, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
Edit note in about `onread` option to `socket.connect()` for clarity.

PR-URL: #30691
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Nov 30, 2019

Landed in 1b11039

@addaleax addaleax closed this Nov 30, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
Edit note in about `onread` option to `socket.connect()` for clarity.

PR-URL: #30691
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos added a commit that referenced this pull request Dec 5, 2019
Edit note in about `onread` option to `socket.connect()` for clarity.

PR-URL: #30691
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
Edit note in about `onread` option to `socket.connect()` for clarity.

PR-URL: nodejs#30691
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Edit note in about `onread` option to `socket.connect()` for clarity.

PR-URL: #30691
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.