Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: address nits for src/README.md #30693

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

addaleax commented Nov 28, 2019

Refs: #30552 (review)

@vsemozhetbyt

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
src/README.md Show resolved Hide resolved
@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Nov 28, 2019

Partial duplicate of #30662.

src/README.md Show resolved Hide resolved
@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Nov 28, 2019

Ah, sorry. Git will rebase out your changes anyway (out of this PR) as they match 1:1, so I think this is still okay.

addaleax added a commit that referenced this pull request Nov 30, 2019
Refs: #30552 (review)

PR-URL: #30693
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Nov 30, 2019

Landed in 0f42727

@addaleax addaleax closed this Nov 30, 2019
@addaleax addaleax deleted the addaleax:cpp-readme-nits branch Nov 30, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
Refs: #30552 (review)

PR-URL: #30693
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos added a commit that referenced this pull request Dec 5, 2019
Refs: #30552 (review)

PR-URL: #30693
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
Refs: nodejs#30552 (review)

PR-URL: nodejs#30693
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Refs: #30552 (review)

PR-URL: #30693
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.