Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add an indicator `isIBMi` #30714

Closed
wants to merge 1 commit into from
Closed

test: add an indicator `isIBMi` #30714

wants to merge 1 commit into from

Conversation

@dmabupt
Copy link
Contributor

dmabupt commented Nov 29, 2019

We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test/common/index.js Outdated Show resolved Hide resolved
@dmabupt dmabupt force-pushed the dmabupt:ibmi_test branch 2 times, most recently from 1e6a326 to 6b44eb5 Nov 29, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 29, 2019

The function/property/whatever-it-ends-up-being should be added to test/common/index.mjs too, I think.

test/common/index.js Outdated Show resolved Hide resolved
test/common/index.js Outdated Show resolved Hide resolved
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 29, 2019

The property added here would also need to be documented in test/common/README.md.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 29, 2019

Thinking about this more, I wonder if the thing to do for now is don't even add it to common. It's only used in one test, so just put the check in the test itself. If we find we need to do this in more places, it can be extracted into common at that time.

@sam-github

This comment has been minimized.

Copy link
Member

sam-github commented Nov 29, 2019

I agree, just testing os.type() in the single affected test is the thing to do here.

@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented Nov 29, 2019

@sam-github thanks for checking that out and I agree with:

I agree, just testing os.type() in the single affected test is the thing to do here.

@dmabupt

This comment has been minimized.

Copy link
Contributor Author

dmabupt commented Nov 30, 2019

There will be more test cases to be skipped in future since some APIs are not supported by IBM i yet, like fs.watch(). And I am working on the list right now. So this is just an initial commit to add this flag to be used in future.

@dmabupt dmabupt force-pushed the dmabupt:ibmi_test branch from 3845ceb to 3e74fa4 Nov 30, 2019
test/common/index.js Outdated Show resolved Hide resolved
Copy link
Member

sam-github left a comment

Other than the inconsistent spelling of IBMi this looks OK to me.

Copy link
Member

Trott left a comment

Needs to be added to index.mjs too. (Feel free to clear this request for changes once that's done.)

We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.
@dmabupt dmabupt force-pushed the dmabupt:ibmi_test branch from 1c132b5 to 1cf3c57 Dec 1, 2019
@dmabupt dmabupt requested a review from Trott Dec 1, 2019
@nodejs-github-bot

This comment has been minimized.

@targos
targos approved these changes Dec 1, 2019
@targos targos dismissed Trott’s stale review Dec 1, 2019

addressed

@jasnell
jasnell approved these changes Dec 1, 2019
@cjihrig
cjihrig approved these changes Dec 1, 2019
richardlau added a commit that referenced this pull request Dec 2, 2019
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Dec 2, 2019

Landed in f0a31e5.

@richardlau richardlau closed this Dec 2, 2019
@dmabupt dmabupt deleted the dmabupt:ibmi_test branch Dec 3, 2019
targos added a commit that referenced this pull request Dec 3, 2019
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos added a commit that referenced this pull request Dec 5, 2019
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
dmabupt added a commit to dmabupt/node that referenced this pull request Dec 6, 2019
@dmabupt dmabupt mentioned this pull request Dec 6, 2019
0 of 2 tasks complete
dmabupt added a commit to dmabupt/node that referenced this pull request Dec 6, 2019
dmabupt added a commit to dmabupt/node that referenced this pull request Dec 9, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: nodejs#30714
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
BridgeAR added a commit that referenced this pull request Dec 25, 2019
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs added a commit that referenced this pull request Dec 31, 2019
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit that referenced this pull request Jan 14, 2020
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.