Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update socket.bufferSize text #30723

Merged
merged 0 commits into from Dec 2, 2019
Merged

doc: update socket.bufferSize text #30723

merged 0 commits into from Dec 2, 2019

Conversation

@Trott
Copy link
Member

Trott commented Nov 30, 2019

Edit text for clarity and readability.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc/api/net.md Outdated Show resolved Hide resolved
@Trott Trott requested a review from addaleax Nov 30, 2019
@Trott Trott added the author ready label Nov 30, 2019
@jasnell
jasnell approved these changes Dec 1, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Dec 2, 2019

Landed in 7f7d858

@Trott Trott closed this Dec 2, 2019
@Trott Trott force-pushed the Trott:currently branch from e494597 to 7f7d858 Dec 2, 2019
@Trott Trott deleted the Trott:currently branch Dec 2, 2019
@Trott Trott merged commit 7f7d858 into nodejs:master Dec 2, 2019
1 check failed
1 check failed
Travis CI - Branch Build Created
Details
targos added a commit that referenced this pull request Dec 2, 2019
Edit text for clarity and readability.

PR-URL: #30723
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos added a commit that referenced this pull request Dec 5, 2019
Edit text for clarity and readability.

PR-URL: #30723
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
Edit text for clarity and readability.

PR-URL: nodejs#30723
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Edit text for clarity and readability.

PR-URL: #30723
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
BethGriggs added a commit that referenced this pull request Dec 31, 2019
Edit text for clarity and readability.

PR-URL: #30723
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.