Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-benchmark-streams #30757

Merged
merged 1 commit into from Dec 2, 2019
Merged

test: fix test-benchmark-streams #30757

merged 1 commit into from Dec 2, 2019

Conversation

@Trott
Copy link
Member

Trott commented Dec 2, 2019

test-benchmark-streams is currently failing because the sync option is
not specified in the test, resulting in too many benchmarks running.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Dec 2, 2019

I'd like to fast-track to fix node-daily-master. Collaborators, please 👍 here to approve.

@nodejs-github-bot

This comment has been minimized.

@Trott Trott added the fast-track label Dec 2, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Dec 2, 2019

CI that includes benchmark tests (queued): https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/10564/

@Trott Trott added the author ready label Dec 2, 2019
@nodejs-github-bot

This comment has been minimized.

test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: #30757
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott Trott force-pushed the Trott:fix-streams branch from f185d31 to cf3a05a Dec 2, 2019
@Trott Trott merged commit cf3a05a into nodejs:master Dec 2, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Dec 2, 2019

Landed in cf3a05a

@Trott Trott deleted the Trott:fix-streams branch Dec 2, 2019
targos added a commit that referenced this pull request Dec 3, 2019
test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: #30757
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos added a commit that referenced this pull request Dec 5, 2019
test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: #30757
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: nodejs#30757
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: #30757
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
BethGriggs added a commit that referenced this pull request Dec 31, 2019
test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: #30757
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.