Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused libraries #30827

Closed
wants to merge 1 commit into from
Closed

Conversation

@juanarbol
Copy link
Contributor

juanarbol commented Dec 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@cjihrig
cjihrig approved these changes Dec 7, 2019
@trivikr
trivikr approved these changes Dec 7, 2019
@trivikr trivikr added the author ready label Dec 7, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Dec 7, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@TimothyGu

This comment has been minimized.

Copy link
Member

TimothyGu commented Dec 9, 2019

Hmm, it appears that at least algorithm and memory are used, since the file explicitly references unique_ptr and find_if. Is there some context I'm missing?

@BridgeAR BridgeAR removed the author ready label Dec 10, 2019
@juanarbol

This comment has been minimized.

Copy link
Contributor Author

juanarbol commented Dec 11, 2019

Sorry, I was based if it compiles, it works or something, so, I just saw a file where inclues specifies the used methods, I did the same here. Thanks @TimothyGu. I'll spend some time searching why this compiles.

@tniessen tniessen dismissed their stale review Dec 11, 2019

Does not apply anymore

@Trott Trott added the author ready label Dec 13, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 14, 2019

The C++ linter is flagging some issues with whitespace. make lint-cpp (or, on Windows, vcbuild lint-cpp) to see the results.

@Trott Trott removed the author ready label Dec 14, 2019
Copy link
Member

richardlau left a comment

Commit message is no longer accurate.

@juanarbol juanarbol force-pushed the juanarbol:cc-unused-libs branch from 9dcdf88 to 9114104 Dec 17, 2019
@richardlau richardlau dismissed their stale review Dec 17, 2019

Commit message has been updated.

@nodejs-github-bot

This comment has been minimized.

@Trott Trott added the author ready label Dec 17, 2019
@nodejs-github-bot

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 20, 2019

Landed in db9539b 🎉

BridgeAR added a commit that referenced this pull request Dec 20, 2019
PR-URL: #30827
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR closed this Dec 20, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #30827
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #30827
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.