Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update message.url example in http.IncomingMessage #30830

Closed
wants to merge 3 commits into from

Conversation

@saitoeku3
Copy link
Contributor

saitoeku3 commented Dec 7, 2019

Update message.url example to use The WHATWG URL API.
This is because the old example suggests using deprecated url API.

Fixes: #30048
Refs: https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_message_url

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Update message.url example to use The WHATWG URL API.
This is because the old example suggests using deprecated url API.

Fixes: #30048
Refs: https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_message_url
doc/api/http.md Outdated Show resolved Hide resolved
doc/api/http.md Outdated Show resolved Hide resolved
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 7, 2019

Wrapped at 80 characters and refactored.

Fixes: #30048
Refs: #30830
@saitoeku3 saitoeku3 requested a review from Trott Dec 8, 2019
@lpinca
lpinca approved these changes Dec 17, 2019
doc/api/http.md Outdated Show resolved Hide resolved
@Trott
Trott approved these changes Dec 18, 2019
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Dec 18, 2019
Update message.url example to use The WHATWG URL API.
This is because the old example suggests using deprecated url API.

Fixes: nodejs#30048
PR-URL: nodejs#30830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 18, 2019

Landed in eaf5975.

Thanks for the contribution! 🎉

@Trott Trott closed this Dec 18, 2019
@saitoeku3 saitoeku3 deleted the saitoeku3:fix-http-doc branch Dec 18, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Update message.url example to use The WHATWG URL API.
This is because the old example suggests using deprecated url API.

Fixes: #30048
PR-URL: #30830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Update message.url example to use The WHATWG URL API.
This is because the old example suggests using deprecated url API.

Fixes: #30048
PR-URL: #30830
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.