Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: add colors to debuglog() #30930

Closed
wants to merge 1 commit into from
Closed

Conversation

@BridgeAR
Copy link
Member

BridgeAR commented Dec 13, 2019

This adds colors to the passed through arguments in case the stream
supports colors. The PID will also be highlighted.

This is especially helpful in case we print errors: core stack frames are going to be greyed out in that case. It should also improve highlighting objects.

image

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
This adds colors to the passed through arguments in case the stream
supports colors. The PID will also be highlighted.
@BridgeAR BridgeAR force-pushed the BridgeAR:add-debuglog-colors branch from c7b7c9a to 5cfca89 Dec 13, 2019
@nodejs-github-bot

This comment was marked as outdated.

Copy link

nodejs-github-bot commented Dec 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27625/ (yellow build with a typical Windows build).

@nodejs-github-bot

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Dec 14, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Dec 19, 2019

@nodejs/util this could use some reviews.

@targos

This comment has been minimized.

Copy link
Member

targos commented Dec 19, 2019

The change LGTM.
Could you post a screenshot example?

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Dec 19, 2019

@targos I updated the initial post with a screenshot.

@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Dec 24, 2019

BridgeAR added a commit that referenced this pull request Dec 25, 2019
This adds colors to the passed through arguments in case the stream
supports colors. The PID will also be highlighted.

PR-URL: #30930
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member Author

BridgeAR commented Dec 25, 2019

Landed in a034583 🎉

@BridgeAR BridgeAR closed this Dec 25, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
This adds colors to the passed through arguments in case the stream
supports colors. The PID will also be highlighted.

PR-URL: #30930
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
@BridgeAR BridgeAR deleted the BridgeAR:add-debuglog-colors branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.