Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: manywrites backpressure #30977

Closed
wants to merge 1 commit into from

Conversation

@ronag
Copy link
Member

ronag commented Dec 15, 2019

Make manywrites benchmark a bit more realistic by taking backpressure into account. Otherwise memory usage would no correspond well with real world usage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@ronag ronag changed the title bench: manywrites back pressure bench: manywrites backpressure Dec 15, 2019
@lpinca
lpinca approved these changes Dec 15, 2019
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Dec 15, 2019

What's the correct "subsystem" for bench?

@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Dec 15, 2019

benchmark

Make manywrites benchmark a bit more realistic by
taking back pressure into account. Otherwise
memory usage would no correspond well with
real world usage.
@ronag ronag force-pushed the nxtedition:manywrites-backpressuse branch from 45cfb45 to b06f8fe Dec 15, 2019
@ronag ronag changed the title bench: manywrites backpressure benchmark: manywrites backpressure Dec 15, 2019
@Fishrock123

This comment has been minimized.

Copy link
Member

Fishrock123 commented Dec 16, 2019

Sure, no good use of streams will cause this, but I do wonder a bit if the old one isn't still useful somehow? Idk.

@Trott
Trott approved these changes Dec 17, 2019
@Trott

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott Trott added the author ready label Dec 17, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 18, 2019

Landed in ea86f8c

@Trott Trott closed this Dec 18, 2019
Trott added a commit that referenced this pull request Dec 18, 2019
Make manywrites benchmark a bit more realistic by
taking back pressure into account. Otherwise
memory usage would no correspond well with
real world usage.

PR-URL: #30977
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Make manywrites benchmark a bit more realistic by
taking back pressure into account. Otherwise
memory usage would no correspond well with
real world usage.

PR-URL: #30977
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Make manywrites benchmark a bit more realistic by
taking back pressure into account. Otherwise
memory usage would no correspond well with
real world usage.

PR-URL: #30977
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.