Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgram: use for...of #30999

Closed
wants to merge 1 commit into from
Closed

dgram: use for...of #30999

wants to merge 1 commit into from

Conversation

@trivikr
Copy link
Member

trivikr commented Dec 16, 2019

Searched for regular expression for \([^\.]*.length in lib and made changes in dgram submodule

Refs: #30910 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@trivikr trivikr force-pushed the trivikr:use-for-of-dgram branch from 09bf808 to 94f2718 Dec 17, 2019
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Dec 20, 2019
trivikr added a commit that referenced this pull request Dec 20, 2019
PR-URL: #30999
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@trivikr

This comment has been minimized.

Copy link
Member Author

trivikr commented Dec 20, 2019

Landed in c68ecee

@trivikr trivikr closed this Dec 20, 2019
@trivikr trivikr deleted the trivikr:use-for-of-dgram branch Dec 20, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #30999
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #30999
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.