Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: correct spelling and grammar #31026

Closed
wants to merge 3 commits into from
Closed

Conversation

@datatypevoid
Copy link
Contributor

datatypevoid commented Dec 19, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
lib/events.js Outdated Show resolved Hide resolved
@Trott
Trott approved these changes Dec 19, 2019
@lpinca
lpinca approved these changes Dec 19, 2019
@nodejs-github-bot

This comment has been minimized.

Trott added a commit that referenced this pull request Dec 22, 2019
PR-URL: #31026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 22, 2019

Landed in 312f308.

Thanks for the contribution! 🎉

@Trott Trott closed this Dec 22, 2019
@datatypevoid datatypevoid deleted the datatypevoid:patch-1 branch Dec 23, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #31026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.