Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix common.enoughTestMem #31035

Merged
merged 0 commits into from Dec 20, 2019
Merged

test: fix common.enoughTestMem #31035

merged 0 commits into from Dec 20, 2019

Conversation

@Trott
Copy link
Member

Trott commented Dec 20, 2019

A typo introduced in 1ddcb6d causes common.enoughTestMem to always
be falsy, resulting in a lot of tests being skipped. Fix the typo.

Collaborators, please 馃憤 to fast-track (or comment if you believe this shouldn't be fast-tracked).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott Trott added fast-track test and removed test labels Dec 20, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Dec 20, 2019

Landed in 118b28a

@Trott Trott closed this Dec 20, 2019
@Trott Trott force-pushed the Trott:fix-mem branch from 0c668db to 118b28a Dec 20, 2019
@Trott Trott merged commit 118b28a into nodejs:master Dec 20, 2019
@Trott Trott deleted the Trott:fix-mem branch Dec 20, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
A typo introduced in 1ddcb6d causes common.enoughTestMem to always
be false, resulting in a lot of tests being skipped. Fix the typo.

PR-URL: #31035
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
A typo introduced in 1ddcb6d causes common.enoughTestMem to always
be false, resulting in a lot of tests being skipped. Fix the typo.

PR-URL: #31035
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can鈥檛 perform that action at this time.