Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix Raspbian armv7 build #31041

Closed
wants to merge 1 commit into from
Closed

tools: fix Raspbian armv7 build #31041

wants to merge 1 commit into from

Conversation

@AHgPuK
Copy link
Contributor

AHgPuK commented Dec 20, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes Dec 20, 2019
@Trott
Trott approved these changes Dec 21, 2019
@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Dec 21, 2019

@Trott Trott added the author ready label Dec 21, 2019
@Trott

This comment has been minimized.

@rvagg

This comment has been minimized.

Copy link
Member

rvagg commented Dec 22, 2019

@AHgPuK what version of Raspbian are you having trouble with and what hardware are you running? Can you give us some error output that demonstrates the need for this change? Our various ARM builds have not had a problem with this but we do a lot of cross compiling now so we could be missing something—it would be good to understand what that might be.

@rvagg

This comment has been minimized.

Copy link
Member

rvagg commented Dec 22, 2019

also compiler version would be nice too

@AHgPuK

This comment has been minimized.

Copy link
Contributor Author

AHgPuK commented Dec 22, 2019

@rvagg
Error message I get: undefined reference to '__atomic_fetch_sub_8'
Raspbian version: Raspbian Buster with desktop
Raspbian build version: Linux pi4 4.19.88-v7l+ #1284 SMP Wed Dec 11 13:51:57 GMT 2019 armv7l
Hardware: Raspberry Pi 4 4Gb RAM
gcc (Raspbian 8.3.0-6+rpi1) 8.3.0

@rvagg

This comment has been minimized.

Copy link
Member

rvagg commented Dec 23, 2019

yeah, ok, we're neither testing Buster, nor GCC 8 yet, so I suppose there's something in this combination that we're not getting.

@AHgPuK AHgPuK changed the title Fix Raspbian armv7 build tools: fix Raspbian armv7 build Dec 24, 2019
BridgeAR added a commit that referenced this pull request Dec 25, 2019
PR-URL: #31041
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 25, 2019

Landed in 1bc7a50 🎉

@BridgeAR BridgeAR closed this Dec 25, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #31041
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31041
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Reda1000 Reda1000 mentioned this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.