Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: use let and const instead of var in cluster #31042

Closed
wants to merge 1 commit into from

Conversation

@dnlup
Copy link
Contributor

dnlup commented Dec 20, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Dec 24, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27902/ (the linter passed and that is all that is actually related to the benchmarks)

@Trott
Trott approved these changes Dec 27, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 27, 2019

Landed in 3cec1a2. (Ran test-benchmark-cluster before landing since that doesn't happen in a regular CI but will happen in a nightly CI job.)

@Trott Trott closed this Dec 27, 2019
Trott added a commit that referenced this pull request Dec 27, 2019
PR-URL: #31042
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #31042
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
@dnlup dnlup deleted the dnlup:benchmark_cluster branch Jan 10, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31042
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.