Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 6.8.0 #31044

Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 6.8.0 #31044

wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Dec 20, 2019

Update ESLint to 6.8.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Update ESLint to 6.8.0
Copy link
Member

BridgeAR left a comment

RSLGTM

@Trott
Trott approved these changes Dec 20, 2019
Copy link
Member

Trott left a comment

Rubber-stamp LGTM

Copy link
Member

trivikr left a comment

RSLGTM

@ZYSzys
ZYSzys approved these changes Dec 21, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Dec 22, 2019

@Qard
Qard approved these changes Dec 22, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 23, 2019

Landed in 5a0cd93

@Trott Trott closed this Dec 23, 2019
Trott added a commit that referenced this pull request Dec 23, 2019
Update ESLint to 6.8.0

PR-URL: #31044
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@cjihrig cjihrig deleted the cjihrig:eslint branch Dec 23, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Update ESLint to 6.8.0

PR-URL: #31044
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Update ESLint to 6.8.0

PR-URL: #31044
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.