Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf_hooks: use for...of #31049

Closed
wants to merge 1 commit into from
Closed

perf_hooks: use for...of #31049

wants to merge 1 commit into from

Conversation

@trivikr
Copy link
Member

trivikr commented Dec 21, 2019

Searched for regular expression for \([^\.]*.length in lib and made changes in perf_hooks submodule

Refs: #30910 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@BridgeAR BridgeAR mentioned this pull request Dec 24, 2019
1 of 2 tasks complete
@trivikr trivikr force-pushed the trivikr:perf_hooks_for_of branch from b417754 to 3d03196 Dec 31, 2019
@nodejs-github-bot

This comment has been minimized.

@jasnell
jasnell approved these changes Jan 2, 2020
@BridgeAR BridgeAR mentioned this pull request Jan 2, 2020
2 of 2 tasks complete
@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Jan 4, 2020
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 4, 2020

Landed in bf6b39d

@Trott Trott closed this Jan 4, 2020
Trott added a commit that referenced this pull request Jan 4, 2020
PR-URL: #31049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@trivikr trivikr deleted the trivikr:perf_hooks_for_of branch Jan 4, 2020
targos added a commit that referenced this pull request Jan 6, 2020
PR-URL: #31049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.