Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: use for...of #31051

Closed
wants to merge 1 commit into from
Closed

zlib: use for...of #31051

wants to merge 1 commit into from

Conversation

@trivikr
Copy link
Member

trivikr commented Dec 21, 2019

Searched for regular expression for \([^\.]*.length in lib and made changes in zlib submodule

Refs: #30910 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@BridgeAR BridgeAR mentioned this pull request Dec 24, 2019
1 of 2 tasks complete
@lpinca
lpinca approved these changes Dec 28, 2019
@Trott
Trott approved these changes Dec 29, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 29, 2019

Needs a rebase...

@trivikr trivikr force-pushed the trivikr:zlib-for-of branch from 7a5df81 to dc29c47 Dec 29, 2019
@trivikr

This comment has been minimized.

Copy link
Member Author

trivikr commented Dec 29, 2019

Needs a rebase...

Done!

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 31, 2019

Landed in 0a958f4

@Trott Trott closed this Dec 31, 2019
Trott added a commit that referenced this pull request Dec 31, 2019
PR-URL: #31051
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@trivikr trivikr deleted the trivikr:zlib-for-of branch Dec 31, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #31051
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31051
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31051
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.