Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve doc net:server.listen #31064

Closed
wants to merge 1 commit into from

Conversation

@dev-313
Copy link
Contributor

dev-313 commented Dec 23, 2019

Remove line "Common parameter of server.listen() functions."
from net:server.listen callback functions because there is no
need of this line.

Fixes: #31019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Remove line "Common parameter of server.listen() functions."
from net:server.listen callback functions because there is no
need of this line.

Fixes: #31019
@dev-313 dev-313 force-pushed the dev-313:doc/net-server.listen branch from 1cd5db7 to 9e86e25 Dec 23, 2019
@gireeshpunathil

This comment has been minimized.

BridgeAR added a commit that referenced this pull request Dec 25, 2019
Remove line "Common parameter of server.listen() functions."
from net:server.listen callback functions because there is no
need of this line.

PR-URL: #31064
Fixes: #31019
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 25, 2019

Landed in 5661466 🎉

@BridgeAR BridgeAR closed this Dec 25, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Remove line "Common parameter of server.listen() functions."
from net:server.listen callback functions because there is no
need of this line.

PR-URL: #31064
Fixes: #31019
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Remove line "Common parameter of server.listen() functions."
from net:server.listen callback functions because there is no
need of this line.

PR-URL: #31064
Fixes: #31019
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.