Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: include writev & callback in benchmark #31066

Closed
wants to merge 5 commits into from

Conversation

@ronag
Copy link
Member

ronag commented Dec 23, 2019

Currently we only consider write when benchmarking.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Currently we only consider write when benchmarking.
@ronag ronag changed the title benchmark: include writev in benchmark benchmark: include writev & callback in benchmark Dec 23, 2019
@ronag ronag force-pushed the nxtedition:many-writes-writev branch from 1f863ee to 4155712 Dec 23, 2019
benchmark/streams/writable-manywrites.js Outdated Show resolved Hide resolved
benchmark/streams/writable-manywrites.js Outdated Show resolved Hide resolved
@ronag ronag mentioned this pull request Dec 23, 2019
4 of 4 tasks complete
Copy link
Member

BridgeAR left a comment

This actually requires the following test to be changed:

test/benchmark/test-benchmark-streams.js

@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Dec 24, 2019

This actually requires the following test to be changed:

test/benchmark/test-benchmark-streams.js

Sorry, this is new for me. What is that and how does it need to be changed?

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 24, 2019

If you run the test with this addition, it will fail due to the added options that are not included in the test. It is a way to verify that at least one benchmark option passes for all benchmark files of the specific subsystem.

You could add something like writev: 'yes', callback: 'no'.

@ronag ronag requested a review from BridgeAR Dec 25, 2019
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 25, 2019

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4115/

Marking as author ready. The benchmark test should be run while landing to verify that it works properly.

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 25, 2019

Landed in f68285b 🎉

@BridgeAR BridgeAR closed this Dec 25, 2019
BridgeAR added a commit that referenced this pull request Dec 25, 2019
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Currently we only consider write when benchmarking.

PR-URL: #31066
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.