Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: simplify isBuf #31067

Closed
wants to merge 1 commit into from
Closed

stream: simplify isBuf #31067

wants to merge 1 commit into from

Conversation

@ronag
Copy link
Member

ronag commented Dec 23, 2019

simplify chunk encoding handling

 streams/writable-manywrites.js writev='no' sync='no' n=2000000                  -0.41 %       ±2.03% ±2.69% ±3.47%
 streams/writable-manywrites.js writev='no' sync='yes' n=2000000         ***      6.00 %       ±2.58% ±3.46% ±4.58%
 streams/writable-manywrites.js writev='yes' sync='no' n=2000000                  2.18 %       ±2.43% ±3.22% ±4.15%
 streams/writable-manywrites.js writev='yes' sync='yes' n=2000000                -1.24 %       ±3.16% ±4.25% ±5.60%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@ronag ronag force-pushed the nxtedition:writable-isbuf branch 2 times, most recently from 51b0309 to f2eb4b4 Dec 23, 2019
@ronag ronag force-pushed the nxtedition:writable-isbuf branch from f2eb4b4 to 3d01928 Dec 23, 2019
@nodejs-github-bot

This comment has been minimized.

lib/_stream_writable.js Show resolved Hide resolved
BridgeAR added a commit that referenced this pull request Dec 25, 2019
PR-URL: #31067
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 25, 2019

Landed in cd6b00d 🎉

@BridgeAR BridgeAR closed this Dec 25, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #31067
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31067
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31067
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.