Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: implement minor improvements to BUILDING.md text #31070

Merged
merged 0 commits into from Dec 25, 2019

Conversation

@Trott
Copy link
Member

Trott commented Dec 23, 2019

Fix comma splices. Remove unnecessary words. Minor text improvements.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott Trott added the author ready label Dec 23, 2019
Copy link
Member

MylesBorins left a comment

LGTM

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Dec 23, 2019

fast track?

@lpinca
lpinca approved these changes Dec 23, 2019
@Trott Trott closed this Dec 25, 2019
@Trott Trott force-pushed the Trott:build-tweaks branch from f4c0a62 to 3987901 Dec 25, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Dec 25, 2019

Landed in 3987901

@Trott Trott merged commit 3987901 into nodejs:master Dec 25, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Fix comma splices. Remove unnecessary words. Minor text improvements.

PR-URL: #31070
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Fix comma splices. Remove unnecessary words. Minor text improvements.

PR-URL: #31070
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.