Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update parameters for chmod and chmodsync #31085

Closed
wants to merge 1 commit into from

Conversation

@santoshyadav198613
Copy link
Contributor

santoshyadav198613 commented Dec 24, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@gireeshpunathil

This comment has been minimized.

@Trott
Trott approved these changes Dec 25, 2019
@Trott Trott added the author ready label Dec 25, 2019
@santoshyadav198613 santoshyadav198613 force-pushed the santoshyadav198613:patch-1 branch from b1be525 to b9b5513 Dec 26, 2019
@santoshyadav198613

This comment has been minimized.

Copy link
Contributor Author

santoshyadav198613 commented Dec 26, 2019

Thank you team, I have made the changes in commit message.

@santoshyadav198613 santoshyadav198613 force-pushed the santoshyadav198613:patch-1 branch from b9b5513 to 4b205bd Dec 26, 2019
@devnexen devnexen force-pushed the nodejs:master branch from bdb1194 to 5289f80 Dec 26, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 27, 2019

@santoshyadav198613 Can you update the commit message to include a subsystem, a better description in the header, and punctuation in the body? If you just want to copy/paste, here's what I would recommend:

doc: update parameter type for fs.chmod()

The mode parameter of fs.chmod() and fs.chmodSync() can be a string or 
an integer. This change updates the documentation, which currently omits
string as a valid type for mode. 
@Trott Trott removed the author ready label Dec 27, 2019
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.
@Trott Trott force-pushed the santoshyadav198613:patch-1 branch from 4b205bd to e478ca2 Dec 27, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 27, 2019

doc: update parameter type for fs.chmod()

The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

Never mind. I made the edits myself and pushed it to the branch.

@Trott Trott added the author ready label Dec 27, 2019
@santoshyadav198613 santoshyadav198613 force-pushed the santoshyadav198613:patch-1 branch from e478ca2 to c935580 Dec 27, 2019
@santoshyadav198613

This comment has been minimized.

Copy link
Contributor Author

santoshyadav198613 commented Dec 27, 2019

doc: update parameter type for fs.chmod()
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

Never mind. I made the edits myself and pushed it to the branch.

Sorry I also pushed the same changes.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 27, 2019

Sorry I also pushed the same changes.

Ha ha! Yeah, no problem. Thanks!

@Trott
Trott approved these changes Dec 27, 2019
@santoshyadav198613

This comment has been minimized.

Copy link
Contributor Author

santoshyadav198613 commented Dec 27, 2019

Sorry I also pushed the same changes.

Ha ha! Yeah, no problem. Thanks!

Thanks, this was my first PR sorry for the trouble.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 27, 2019

Landed in 283e7a4.

Thanks for the contribution! 🎉

@Trott Trott closed this Dec 27, 2019
Trott added a commit to Trott/io.js that referenced this pull request Dec 27, 2019
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: nodejs#31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
cjihrig added a commit to cjihrig/node-1 that referenced this pull request Dec 27, 2019
This was overlooked in nodejs#31085.
@cjihrig cjihrig mentioned this pull request Dec 27, 2019
3 of 3 tasks complete
Trott added a commit that referenced this pull request Dec 29, 2019
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
The mode parameter of fs.chmod() and fs.chmodSync() can be a string or
an integer. This change updates the documentation, which currently omits
string as a valid type for mode.

PR-URL: #31085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Jan 14, 2020
This was overlooked in #31085.

PR-URL: #31115
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.