Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: use public getCursorPos() #31091

Merged
merged 1 commit into from Dec 26, 2019
Merged

repl: use public getCursorPos() #31091

merged 1 commit into from Dec 26, 2019

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Dec 25, 2019

_getCursorPos() recently became public API. This commit updates the remaining uses of _getCursorPos() to use the public API.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Dec 25, 2019

Fast track?

@addaleax addaleax added the fast-track label Dec 25, 2019
@nodejs-github-bot

This comment has been minimized.

@targos
targos approved these changes Dec 25, 2019
@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Dec 25, 2019

_getCursorPos() recently became public API. This commit updates
the remaining uses of _getCursorPos() to use the public API.

PR-URL: #31091
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cjihrig cjihrig force-pushed the cjihrig:public branch from b2c1501 to befff8f Dec 26, 2019
@cjihrig cjihrig merged commit befff8f into nodejs:master Dec 26, 2019
@cjihrig cjihrig deleted the cjihrig:public branch Dec 26, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
_getCursorPos() recently became public API. This commit updates
the remaining uses of _getCursorPos() to use the public API.

PR-URL: #31091
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.