Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase coverage for _http_incoming.js #31093

Closed
wants to merge 0 commits into from

Conversation

@Trott
Copy link
Member

Trott commented Dec 25, 2019

Add coverage for IncomingMessage.prototype.connection setter.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@Trott Trott added the author ready label Dec 25, 2019
@ZYSzys
ZYSzys approved these changes Dec 26, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Dec 28, 2019

Landed in 1929135

Trott added a commit to Trott/io.js that referenced this pull request Dec 28, 2019
Add coverage for IncomingMessage.prototype.connection setter.

PR-URL: nodejs#31093
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@Trott Trott closed this Dec 28, 2019
@Trott Trott force-pushed the Trott:connection-setter branch from d6d40a2 to 1929135 Dec 28, 2019
@Trott Trott deleted the Trott:connection-setter branch Dec 28, 2019
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Add coverage for IncomingMessage.prototype.connection setter.

PR-URL: #31093
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.