Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch realpath to pwd #31095

Closed
wants to merge 3 commits into from
Closed

build: switch realpath to pwd #31095

wants to merge 3 commits into from

Conversation

@bcoe
Copy link
Member

bcoe commented Dec 26, 2019

Our test coverage linux machine doesn't have the realpath bin, which I believe comes in as part of coreutils?

This became an issue in #30954, which I believe caused realpath to start getting invoked on these machines for the first time.

I believe we can simply swap out the use of realpath to pwd, for our purposes.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 26, 2019

Our test coverage linux machine doesn't have the realpath bin, which I believe comes in as part of coreutils?

@nodejs/build

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 26, 2019

I believe we can simply swap out the use of realpath to pwd, for our purposes.

@nodejs/python @nodejs/build-files

Copy link
Member

addaleax left a comment

Do we need the prefix at all? Other parts of node.gypi also refer to source tree files using relative paths, so I’d expect that to work too

@nodejs-github-bot

This comment was marked as outdated.

@bcoe bcoe force-pushed the bcoe:build-realpath branch from 8b02257 to 6c878a9 Dec 26, 2019
@nodejs-github-bot

This comment was marked as outdated.

Copy link

nodejs-github-bot commented Dec 26, 2019

@bcoe

This comment has been minimized.

Copy link
Member Author

bcoe commented Dec 26, 2019

@addaleax having experimented with our CI, it does seem that the path provided to the linker needs to be absolute; I've reverted to the prior pwd approach, and it seems to be working like a charm. I think pwd will be more universally available out of the gate, than realpath.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 27, 2019

Maybe fast track this to fix the coverage builds?

gabrielschulhof added a commit that referenced this pull request Dec 27, 2019
PR-URL: #31095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gabrielschulhof

This comment has been minimized.

Copy link
Contributor

gabrielschulhof commented Dec 27, 2019

Landed in ce0fb0f.

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 27, 2019
PR-URL: nodejs#31095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 27, 2019
PR-URL: nodejs#31095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 27, 2019
PR-URL: nodejs#31095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 27, 2019
PR-URL: nodejs#31095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2019
PR-URL: nodejs#31095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 31, 2019
PR-URL: nodejs#31095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #31095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
MylesBorins added a commit that referenced this pull request Jan 8, 2020
Backport-PR-URL: #31063
PR-URL: #31095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.