Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: bump v8_embedder_string for 0e21c1e637bf #31096

Conversation

@ChALkeR
Copy link
Member

ChALkeR commented Dec 26, 2019

0e21c1e has landed without a proper v8_embedder_string bump, this is a follow-up fix.

Refs: 0e21c1e
Refs: #31007

The alternative would be to revert 0e21c1e (PR: #31098) and re-land #31007. Filing both to speed up things.

0e21c1e has landed without a proper
v8_embedder_string bump, this is a follow-up fix.

Refs: 0e21c1e
Refs: #31007
@ChALkeR ChALkeR added the V8 Engine label Dec 26, 2019
@ChALkeR ChALkeR requested a review from BridgeAR Dec 26, 2019
Copy link
Member

addaleax left a comment

This LGTM and I’d prefer this approach over a revert, but tbh, I’m good with just leaving this alone and doing nothing.

(Maybe to expand on that: The commit just before the landed on already bumps the embedder string. There isn’t any point in re-incrementing it, as far as I can tell.)

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 27, 2019

@addaleax

There isn’t any point in re-incrementing it, as far as I can tell.

Shouldn't each individual backport commit bump the embedder string?

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Dec 27, 2019

@BridgeAR Afaik, the only purpose of the embedder string is to identify a specific modified version of V8. If two V8 changes land right next to each other, why do we need to bump the string twice?

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 28, 2019

Sounds like this has become unnecessary. I'm closing it, but of course feel free to re-open if you think I'm wrong to close it.

@Trott Trott closed this Dec 28, 2019
@MylesBorins MylesBorins reopened this Dec 28, 2019
Copy link
Member

MylesBorins left a comment

LGTM

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Dec 28, 2019

For clarity I reopened this PR because I think simply bumping the embedder string is a better course of action than reverting and relanding the other PR

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Dec 28, 2019

The revert being #31098

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 28, 2019

For clarity I reopened this PR because I think simply bumping the embedder string is a better course of action than reverting and relanding the other PR

I closed it because I thought there was consensus on the third option: Do nothing because the string got bumped elsewhere in the meantime. (At least that was my interpretation of #31096 (review) and #31096 (comment) but maybe I'm misunderstanding something.)

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Dec 28, 2019

We have generally bumped the string for every commit. Just because they came in the same PR doesn't mean they are treated as a single atomic change for the bump

At least that is how I've understood it to have been done up until this point.

We can choose to do nothing, but I think the bump in a separate commit is the correct action. Either of those are better than revert and reland imho

@Trott
Trott approved these changes Dec 29, 2019
Copy link
Member

Trott left a comment

I'm fine with the "do nothing" option too.

BridgeAR added a commit that referenced this pull request Jan 1, 2020
0e21c1e has landed without a proper
v8_embedder_string bump, this is a follow-up fix.

PR-URL: #31096
Refs: 0e21c1e
Refs: #31007
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 1, 2020

Landed in 9b0cbcf 🎉

I went ahead and landed it. That way it's consistent with the way we handled it so far.

@BridgeAR BridgeAR closed this Jan 1, 2020
BridgeAR added a commit that referenced this pull request Jan 3, 2020
0e21c1e has landed without a proper
v8_embedder_string bump, this is a follow-up fix.

PR-URL: #31096
Refs: 0e21c1e
Refs: #31007
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.