Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: add benchmark on async_hooks enabled http server #31100

Closed
wants to merge 3 commits into from

Conversation

@legendecas
Copy link
Member

legendecas commented Dec 26, 2019

Refs: nodejs/diagnostics#124

FWIW following is the result of the benchmark:

async_hooks/http-server.js connections=50 asyncHooks="init" benchmarker="autocannon": 31,934.4
async_hooks/http-server.js connections=500 asyncHooks="init" benchmarker="autocannon": 31,830.4
async_hooks/http-server.js connections=50 asyncHooks="before" benchmarker="autocannon": 33,041.6
async_hooks/http-server.js connections=500 asyncHooks="before" benchmarker="autocannon": 30,643.2
async_hooks/http-server.js connections=50 asyncHooks="after" benchmarker="autocannon": 32,300.8
async_hooks/http-server.js connections=500 asyncHooks="after" benchmarker="autocannon": 29,969.6
async_hooks/http-server.js connections=50 asyncHooks="all" benchmarker="autocannon": 33,208
async_hooks/http-server.js connections=500 asyncHooks="all" benchmarker="autocannon": 32,388.8
async_hooks/http-server.js connections=50 asyncHooks="disabled" benchmarker="autocannon": 34,539.2
async_hooks/http-server.js connections=500 asyncHooks="disabled" benchmarker="autocannon": 32,571.2
async_hooks/http-server.js connections=50 asyncHooks="none" benchmarker="autocannon": 34,468.81
async_hooks/http-server.js connections=500 asyncHooks="none" benchmarker="autocannon": 31,824
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Copy link
Member

Trott left a comment

This breaks test/benchmark/test-benchmark-async-hooks.js (which isn't run on every pull request but is run on nightly runs). You'll want to add the asyncHooks and c settings to that test. (Or add asyncHooks only and rename c to n in this benchmark.)

Feel free to dismiss this "request changes" review once the test is updated and passing.

@legendecas legendecas force-pushed the legendecas:benchmark-async-hooks branch 2 times, most recently from 0795d79 to e57bf76 Jan 1, 2020
@legendecas legendecas force-pushed the legendecas:benchmark-async-hooks branch from e57bf76 to 500b240 Jan 1, 2020
@Trott
Trott approved these changes Jan 1, 2020
@jasnell
jasnell approved these changes Jan 2, 2020
@legendecas

This comment has been minimized.

Copy link
Member Author

legendecas commented Jan 2, 2020

Just updated the ordering according to @Trott 's suggestion.

BridgeAR added a commit that referenced this pull request Jan 2, 2020
PR-URL: #31100
Refs: nodejs/diagnostics#124
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 2, 2020

Landed in bf7265f 🎉

@BridgeAR BridgeAR closed this Jan 2, 2020
@legendecas legendecas deleted the legendecas:benchmark-async-hooks branch Jan 3, 2020
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #31100
Refs: nodejs/diagnostics#124
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31100
Refs: nodejs/diagnostics#124
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.