Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: warn upon --use-largepages config option #31103

Conversation

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Dec 26, 2019

Emit a warning when the user configures with --use-largepages and/or
--use-largepages-script-lld informing them that the option is now
available as a Node.js runtime option once it is built.

Re: #31063 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Dec 27, 2019

Minor nit: the “Re:” in the commit message would usually be “Refs:”.

@gabrielschulhof gabrielschulhof force-pushed the gabrielschulhof:warn-about-largepages-compile-time branch from 586642b to 38d4ed2 Dec 27, 2019
@gabrielschulhof

This comment has been minimized.

Copy link
Contributor Author

gabrielschulhof commented Dec 27, 2019

@richardlau I fixed the commit message.

configure.py Outdated Show resolved Hide resolved
@gabrielschulhof gabrielschulhof force-pushed the gabrielschulhof:warn-about-largepages-compile-time branch from 96c0b33 to 06d93fa Dec 27, 2019
Emit a warning when the user configures with `--use-largepages` and/or
`--use-largepages-script-lld` informing them that the option is now
available as a Node.js runtime option once it is built.

Refs: #31063 (comment)
@gabrielschulhof gabrielschulhof force-pushed the gabrielschulhof:warn-about-largepages-compile-time branch from 06d93fa to 3d7f054 Dec 27, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Dec 27, 2019

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Dec 27, 2019

gabrielschulhof added a commit that referenced this pull request Dec 28, 2019
Emit a warning when the user configures with `--use-largepages` and/or
`--use-largepages-script-lld` informing them that the option is now
available as a Node.js runtime option once it is built.

Refs: #31063 (comment)
PR-URL: #31103
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@gabrielschulhof

This comment has been minimized.

Copy link
Contributor Author

gabrielschulhof commented Dec 28, 2019

Landed in c6822be.

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2019
Emit a warning when the user configures with `--use-largepages` and/or
`--use-largepages-script-lld` informing them that the option is now
available as a Node.js runtime option once it is built.

Refs: nodejs#31063 (comment)
PR-URL: nodejs#31103
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2019
Emit a warning when the user configures with `--use-largepages` and/or
`--use-largepages-script-lld` informing them that the option is now
available as a Node.js runtime option once it is built.

Refs: nodejs#31063 (comment)
PR-URL: nodejs#31103
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2019
Emit a warning when the user configures with `--use-largepages` and/or
`--use-largepages-script-lld` informing them that the option is now
available as a Node.js runtime option once it is built.

Refs: nodejs#31063 (comment)
PR-URL: nodejs#31103
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Dec 31, 2019
Emit a warning when the user configures with `--use-largepages` and/or
`--use-largepages-script-lld` informing them that the option is now
available as a Node.js runtime option once it is built.

Refs: nodejs#31063 (comment)
PR-URL: nodejs#31103
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Emit a warning when the user configures with `--use-largepages` and/or
`--use-largepages-script-lld` informing them that the option is now
available as a Node.js runtime option once it is built.

Refs: #31063 (comment)
PR-URL: #31103
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
MylesBorins added a commit that referenced this pull request Jan 8, 2020
Emit a warning when the user configures with `--use-largepages` and/or
`--use-largepages-script-lld` informing them that the option is now
available as a Node.js runtime option once it is built.

Refs: #31063 (comment)
Backport-PR-URL: #31063
PR-URL: #31103
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.