Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: use let instead of var in crypto #31135

Closed
wants to merge 1 commit into from

Conversation

@dnlup
Copy link
Contributor

dnlup commented Dec 30, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@trivikr
trivikr approved these changes Jan 1, 2020
@Trott
Trott approved these changes Jan 1, 2020
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 1, 2020

I ran test/benchmark/test-benchmark-crypto.js locally with this change to confirm it didn't break anything. (That test isn't run in our regular CI, only nightly.)

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 1, 2020

Landed in 7365000

@Trott Trott closed this Jan 1, 2020
Trott added a commit that referenced this pull request Jan 1, 2020
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
@dnlup dnlup deleted the dnlup:benchmark_crypto branch Jan 10, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.