Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: support prepareSourceMap with source-maps #31143

Closed
wants to merge 4 commits into from

Conversation

@bcoe
Copy link
Member

bcoe commented Dec 31, 2019

Adds support for Error.prepareStackTrace override, when --enable-source-maps is set.

See related #31132

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@bcoe bcoe requested review from addaleax, joyeecheung and devsnek Dec 31, 2019
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@bcoe bcoe force-pushed the bcoe:prepare-stack-trace branch from e4b6622 to abebd8f Dec 31, 2019
@nodejs-github-bot

This comment was marked as outdated.

@bcoe bcoe changed the title error: support prepareSourceMap with source-maps errors: support prepareSourceMap with source-maps Dec 31, 2019
@bcoe bcoe force-pushed the bcoe:prepare-stack-trace branch from abebd8f to 19a1979 Dec 31, 2019
@nodejs-github-bot

This comment was marked as outdated.

bcoe added 3 commits Dec 31, 2019
@nodejs-github-bot

This comment was marked as outdated.

@jasnell
jasnell approved these changes Jan 2, 2020
@nodejs-github-bot

This comment has been minimized.

@bcoe bcoe added the fast-track label Jan 2, 2020
@bcoe

This comment has been minimized.

Copy link
Member Author

bcoe commented Jan 2, 2020

looks like tests are green; I would love to fast track this if no one objects?

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 2, 2020

@bcoe no need to fast-track this, it may already land. It's open for more than two days and has at least two sign offs.

@BridgeAR BridgeAR added errors and removed fast-track labels Jan 2, 2020
bcoe added a commit that referenced this pull request Jan 2, 2020
Adds support for Error.prepareStackTrace override, when
--enable-source-maps is set.

PR-URL: #31143
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@bcoe bcoe closed this Jan 2, 2020
@bcoe bcoe deleted the bcoe:prepare-stack-trace branch Jan 2, 2020
@bcoe

This comment has been minimized.

Copy link
Member Author

bcoe commented Jan 2, 2020

Landed in 9cdda60

BridgeAR added a commit that referenced this pull request Jan 3, 2020
Adds support for Error.prepareStackTrace override, when
--enable-source-maps is set.

PR-URL: #31143
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Adds support for Error.prepareStackTrace override, when
--enable-source-maps is set.

PR-URL: #31143
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.