Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: group all properties using defineProperties #31144

Closed
wants to merge 1 commit into from

Conversation

@antsmartian
Copy link
Contributor

antsmartian commented Dec 31, 2019

Simple refactor. Moved all the property definition into a single block and removed duplicated comments across the file.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 31, 2019

Copy link
Member

mcollina left a comment

lgtm

@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes Jan 1, 2020
@ronag
ronag approved these changes Jan 1, 2020
Copy link
Member

ronag left a comment

Nice

@ZYSzys
ZYSzys approved these changes Jan 2, 2020
@jasnell
jasnell approved these changes Jan 2, 2020
BridgeAR added a commit that referenced this pull request Jan 2, 2020
PR-URL: #31144
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 2, 2020

Landed in 2257e80 🎉

@BridgeAR BridgeAR closed this Jan 2, 2020
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #31144
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ronag

This comment has been minimized.

Copy link
Member

ronag commented Jan 4, 2020

@antsmartian: Would you mind doing the same for Writable and Duplex?

@antsmartian antsmartian mentioned this pull request Jan 5, 2020
0 of 4 tasks complete
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31144
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31144
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.