Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Enhance use of Set with primordials #31154

Closed

Conversation

@Sebastien-Ahkrin
Copy link
Contributor

Sebastien-Ahkrin commented Jan 2, 2020

Hello :D (i'm back)
For this PR I have added Set in the primordials eslint

And i just have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: Set
        message: "Use `const { Set } = primordials;` instead of the global."

And just add Set.

const {
  // [...]
  Set,
} = primordials;

I hope this new PR will help you :x

@Sebastien-Ahkrin

This comment has been minimized.

Copy link
Contributor Author

Sebastien-Ahkrin commented Jan 2, 2020

Refs: #30697

@nodejs-github-bot

This comment has been minimized.

@jasnell
jasnell approved these changes Jan 2, 2020
@cjihrig
cjihrig approved these changes Jan 2, 2020
@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Jan 4, 2020
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 4, 2020

Whoever lands this might wish to update the commit message to lib: use primordial for Set or something like that perhaps.

@trivikr
trivikr approved these changes Jan 4, 2020
@Sebastien-Ahkrin Sebastien-Ahkrin force-pushed the Sebastien-Ahkrin:SetPrimordials branch from f0ade1e to 015e801 Jan 4, 2020
@nodejs-github-bot

This comment has been minimized.

lib/.eslintrc.yaml Show resolved Hide resolved
Trott added a commit that referenced this pull request Jan 4, 2020
PR-URL: #31154
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 4, 2020

Landed in 256c9a4

@Trott Trott closed this Jan 4, 2020
targos added a commit that referenced this pull request Jan 6, 2020
PR-URL: #31154
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31154
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.