Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: enhance use of Map with primordials #31155

Closed

Conversation

@Sebastien-Ahkrin
Copy link
Contributor

Sebastien-Ahkrin commented Jan 2, 2020

Hello,
Now, in this PR I have added Map in the primordials eslint
so have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: Map
        message: "Use `const { Map } = primordials;` instead of the global."

And just import Map in some file :).

const {
  // [...]
  Map,
} = primordials;

I hope this new PR will help you :x

@Sebastien-Ahkrin

This comment has been minimized.

Copy link
Contributor Author

Sebastien-Ahkrin commented Jan 2, 2020

Refs: #30697

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 2, 2020

I know we also have a SafeMap. Do we still need both? Or is it enough to rely upon the primordial Map? Similar would apply to Set and their weak counterparts.

// cc @devsnek @targos

@nodejs-github-bot

This comment has been minimized.

@jasnell
jasnell approved these changes Jan 2, 2020
@targos
targos approved these changes Jan 2, 2020
@targos

This comment has been minimized.

Copy link
Member

targos commented Jan 2, 2020

SafeMap is not exactly the same, as it also provides safe calls to the prototype methods.

@cjihrig
cjihrig approved these changes Jan 2, 2020
@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Jan 4, 2020
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 4, 2020

Commit message might be clearer as lib: use primordial for Map? That can be edited by whoever lands this, though.

@trivikr
trivikr approved these changes Jan 4, 2020
@Sebastien-Ahkrin Sebastien-Ahkrin force-pushed the Sebastien-Ahkrin:MapPrimordials branch from e8b4be2 to 01c67c7 Jan 4, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 4, 2020

Landed in 9085c03

@Trott Trott closed this Jan 4, 2020
Trott added a commit that referenced this pull request Jan 4, 2020
PR-URL: #31155
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Jan 6, 2020
PR-URL: #31155
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31155
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.