Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: enhance use of WeakSet with primordials #31157

Closed

Conversation

@Sebastien-Ahkrin
Copy link
Contributor

Sebastien-Ahkrin commented Jan 2, 2020

Hello,
Now, in this PR I have added WeakSet in the primordials eslint
so have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: WeakSet 
        message: "Use `const { WeakSet } = primordials;` instead of the global."

And just import WeakSet in one file actually like that :).

const {
  // [...]
  WeakSet,
} = primordials;

I hope this new PR will help you :x

@Sebastien-Ahkrin

This comment has been minimized.

Copy link
Contributor Author

Sebastien-Ahkrin commented Jan 2, 2020

Refs: #30697

@nodejs-github-bot

This comment has been minimized.

@jasnell
jasnell approved these changes Jan 2, 2020
@cjihrig
cjihrig approved these changes Jan 2, 2020
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 4, 2020

The commit message seems unclear to me. It's possible the problem is me and not the commit message, but if not, maybe something more like this?

repl: use primordial for WeakSet
@Trott
Trott approved these changes Jan 4, 2020
@trivikr
trivikr approved these changes Jan 4, 2020
@Sebastien-Ahkrin Sebastien-Ahkrin force-pushed the Sebastien-Ahkrin:WeakSetPrimordials branch from 54f616d to 1ed138c Jan 4, 2020
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 4, 2020

Landed in 5dc55ed

@Trott Trott closed this Jan 4, 2020
Trott added a commit that referenced this pull request Jan 4, 2020
PR-URL: #31157
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Jan 6, 2020
PR-URL: #31157
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31157
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.