Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: enhance use of WeakMap with primordials #31158

Closed

Conversation

@Sebastien-Ahkrin
Copy link
Contributor

Sebastien-Ahkrin commented Jan 2, 2020

Hello,
Now, I have added WeakMap in the primordials eslint
so have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: WeakMap 
        message: "Use `const { WeakMap } = primordials;` instead of the global."

And just import WeakMap in one file actually like that :).

const {
  // [...]
  WeakMap,
} = primordials;

Thanks to allow me to create some PR btw 馃槃
I hope this will be helpful for you

@Sebastien-Ahkrin

This comment has been minimized.

Copy link
Contributor Author

Sebastien-Ahkrin commented Jan 2, 2020

Refs: #30697

@nodejs-github-bot

This comment has been minimized.

@jasnell
jasnell approved these changes Jan 2, 2020
@cjihrig
cjihrig approved these changes Jan 2, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Jan 4, 2020
@nodejs-github-bot

This comment has been minimized.

@trivikr
trivikr approved these changes Jan 4, 2020
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 4, 2020

For whoever lands this, consider making the commit message something like lib: use primordial for WeakMap

@Sebastien-Ahkrin

This comment has been minimized.

Copy link
Contributor Author

Sebastien-Ahkrin commented Jan 4, 2020

For whoever lands this, consider making the commit message something like lib: use primordial for WeakMap

Do you want i change the commit message ? 馃槃 @Trott

@Sebastien-Ahkrin Sebastien-Ahkrin force-pushed the Sebastien-Ahkrin:WeakMapPrimordials branch from 5bc8248 to 7527c46 Jan 4, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 4, 2020

Landed in f509aaa

@Trott Trott closed this Jan 4, 2020
Trott added a commit to Trott/io.js that referenced this pull request Jan 4, 2020
PR-URL: nodejs#31158
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Jan 6, 2020
PR-URL: #31158
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31158
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.